Skip to content

delete js prod command#6323

Merged
adhami3310 merged 1 commit intomainfrom
delete-js-prod-command
Apr 10, 2026
Merged

delete js prod command#6323
adhami3310 merged 1 commit intomainfrom
delete-js-prod-command

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 10, 2026

Greptile Summary

This PR removes the get_prod_command static method from PackageJson.Commands in installer.py and its corresponding parametrized test in test_prerequisites.py. The method generated a sirv CLI command to serve the React production build with a dynamic 404 fallback path based on frontend_path. No remaining call sites for this method exist in the codebase, making the deletion clean.

Confidence Score: 5/5

Safe to merge — purely removes dead code with no remaining call sites.

The deletion is complete: no references to get_prod_command or sirv remain anywhere in the repository, and the corresponding test is cleanly removed. There are no logic, syntax, or security concerns.

No files require special attention.

Important Files Changed

Filename Overview
packages/reflex-base/src/reflex_base/constants/installer.py Removes the get_prod_command static method from PackageJson.Commands; no remaining references exist in the repo.
tests/units/test_prerequisites.py Removes the test_get_prod_command parametrized test and the now-unused PackageJson import, keeping the test file consistent with the deleted implementation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PackageJson.Commands] --> B["DEV = react-router dev --host"]
    A --> C["EXPORT = react-router build"]
    D["get_prod_command - REMOVED"] -. was part of .-> A
    D -. generated .-> E["sirv ./build/client --single 404.html --host"]
Loading

Reviews (1): Last reviewed commit: "delete js prod command" | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 10, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing delete-js-prod-command (1ae0973) with main (ecccd05)

Open in CodSpeed

@adhami3310 adhami3310 merged commit 69a5cee into main Apr 10, 2026
40 checks passed
@adhami3310 adhami3310 deleted the delete-js-prod-command branch April 10, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants